[PATCH] D16878: [POLLY] Support accesses with differently sized types to the same array

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 04:34:26 PST 2016


Meinersbur added inline comments.

================
Comment at: include/polly/Support/ScopHelper.h:151
@@ -141,3 +150,3 @@
   llvm::Value *getValueOperand() const {
     if (isLoad())
       return asLoad();
----------------
jdoerfert wrote:
> This method (as well as most of the ones above) is now just a plain wrapper around the same one in llvm::Instruction. I argued this before and will do it again: __ Do not copy all these functions but instead use the original __
> 
> 
> ```
> MAcc.asInstruction()->getDebugLoc();
> ```
> 
> is not soo bad is it?
The model CallSite class also has some of these forwarders. In my original design, MemAccInst was derived from llvm::Instruction st this was no issue.

Suggestion:
```
Instruction *operator->() const { return I; }
```
and use like this:
```
MAcc->getDebugLoc();
``` 


http://reviews.llvm.org/D16878





More information about the llvm-commits mailing list