[PATCH] D16875: MemorySSA Optimizations: Patch 1 of N

[George Burgess IV via llvm-commits]

george.burgess.iv added inline comments.

================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:940
@@ +939,3 @@
+  //
+  // TODO(gbiv): We should handle invariant groups, as well. It's a bit harder,
+  // because we need to pay close attention to invariant group barriers.
----------------
majnemer wrote:
> TODO(username) is more of a Google-ism, I don't think LLVM does this very often.
Works for me! Thanks for the heads up

================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:942-943
@@ +941,4 @@
+  // because we need to pay close attention to invariant group barriers.
+  if (isa<LoadInst>(I) && (I->getMetadata(LLVMContext::MD_invariant_load) ||
+       AA->pointsToConstantMemory(I))) {
+    doCacheInsert(StartingAccess, MSSA->getLiveOnEntryDef(), Q, Q.StartingLoc);
----------------
majnemer wrote:
> Is this clang-format'd?
It is now :)


http://reviews.llvm.org/D16875