[PATCH] D16875: MemorySSA Optimizations: Patch 1 of N

[Xinliang David Li via llvm-commits]

On Wed, Feb 3, 2016 at 9:38 PM, David Majnemer <david.majnemer at gmail.com> wrote:
> majnemer added a subscriber: majnemer.
>
> ================
> Comment at: lib/Transforms/Utils/MemorySSA.cpp:940
> @@ +939,3 @@
> +  //
> +  // TODO(gbiv): We should handle invariant groups, as well. It's a bit harder,
> +  // because we need to pay close attention to invariant group barriers.
> ----------------
> TODO(username) is more of a Google-ism, I don't think LLVM does this very often.

use //FIXME: instead.

David

>
> ================
> Comment at: lib/Transforms/Utils/MemorySSA.cpp:942-943
> @@ +941,4 @@
> +  // because we need to pay close attention to invariant group barriers.
> +  if (isa<LoadInst>(I) && (I->getMetadata(LLVMContext::MD_invariant_load) ||
> +       AA->pointsToConstantMemory(I))) {
> +    doCacheInsert(StartingAccess, MSSA->getLiveOnEntryDef(), Q, Q.StartingLoc);
> ----------------
> Is this clang-format'd?
>
>
> http://reviews.llvm.org/D16875
>
>
>