[PATCH] D16874: [NVPTX] Disable performance optimizations when OptLevel==None

Jingyue Wu via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 20:18:58 PST 2016


jingyue added inline comments.

================
Comment at: lib/Target/NVPTX/NVPTXTargetMachine.cpp:146
@@ -145,3 +145,3 @@
 private:
-  // if the opt level is aggressive, add GVN; otherwise, add EarlyCSE.
+  // If the opt level is aggressive, add GVN; otherwise, add EarlyCSE.
   void addEarlyCSEOrGVNPass();
----------------
eliben wrote:
> Is EarlyCSE required for correctness? Might worth pointing out why it stays in non-opt mode
Added more comments. This function is only called in opt mode, so its behavior when OptLevel is None doesn't matter. 


http://reviews.llvm.org/D16874





More information about the llvm-commits mailing list