[PATCH] D16831: [regalloc][WinEH] Do not mark intervals as not spillable if they contain a regmask

Andy Kaylor via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 12:55:42 PST 2016


andrew.w.kaylor added inline comments.

================
Comment at: test/CodeGen/X86/regalloc-spill-at-ehpad.ll:10
@@ +9,3 @@
+
+; The following checks that the value %p is reloaded within the catch handler.
+; CHECK-LABEL: "?catch$8@?0?test at 4HA":
----------------
I'm not sure I can verify the actual split without dumping the debug output.  I could do that, I suppose, but the important thing isn't that a particular interval is split but rather than the value is spilled across the unwind edge.  I don't want the test to become flaky if the interval splitting algorithm is updated.

I've added a check to verify that the value is reloaded in the catch handler.


Repository:
  rL LLVM

http://reviews.llvm.org/D16831





More information about the llvm-commits mailing list