[PATCH] D16832: Minor performance tweaks to llvm-tblgen (and a few that might be a good idea)

Alexander Riccio via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 10:57:33 PST 2016


ariccio added a comment.

In http://reviews.llvm.org/D16832#343220, @rnk wrote:

> lgtm, do you need someone to commit this?


Yup, no privs.

Although, if `SCPair.first->getNameInit()->getValue()`


================
Comment at: C:/LLVM/llvm/include/llvm/TableGen/Record.h:1312
@@ -1311,2 +1311,3 @@
       if (SCPair.first->getNameInitAsString() == Name)
         return true;
+    }
----------------
rnk wrote:
> This should do the trick:
>   if (SCPair.first->getNameInit()->getValue() == Name)
> 
Does that return the equivalent string vs `getAsUnquotedString`?


http://reviews.llvm.org/D16832





More information about the llvm-commits mailing list