[PATCH] D16831: [regalloc][WinEH] Do not mark intervals as not spillable if they contain a regmask

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 10:08:14 PST 2016


rnk added a comment.

Nice fix!


================
Comment at: include/llvm/CodeGen/LiveInterval.h:550
@@ +549,3 @@
+    // the interval may be required.
+    bool containsRegMask(ArrayRef<SlotIndex> RegMaskSlots) const {
+      ArrayRef<SlotIndex>::iterator SlotI = RegMaskSlots.begin();
----------------
This seems like it shouldn't be inline.

================
Comment at: test/CodeGen/X86/regalloc-spill-at-ehpad.ll:9
@@ +8,3 @@
+
+; CHECK-NOT: LLVM ERROR
+
----------------
qcolombet wrote:
> Could you check that the splitting you expect occur?
+1


Repository:
  rL LLVM

http://reviews.llvm.org/D16831





More information about the llvm-commits mailing list