[PATCH] D16835: InstCombine: Restrict computeKnownBits() on everyValue to OptLevel > 2

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 18:45:55 PST 2016


Given that I don't have a single file in the whole llvm-testsuite where this transformation kicks in I wouldn't know how to start tuning it, so this patch simply pushes it to -O3 only.

> On Feb 2, 2016, at 6:40 PM, Mehdi AMINI via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> joker.eph added a comment.
> 
> Two questions on the concept:
> 
> - Are we sure that a boolean is enough? (per comparison to a "level", like Opt_level).
> - The trigger between expensive combine or not could (should?) be adjusted depending on where we stand in the pipeline (I mean not always turning it on or off depending on the opt level, but also depending on the position in the pipeline)
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D16835
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list