[PATCH] D16712: [LoopVersioning] Annotate versioned loop with noalias metadata

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 11:18:41 PST 2016


anemet updated this revision to Diff 46682.
anemet retitled this revision from "[LoopVectorizer/LoopVersioning] Annotate versioned loop with noalias metadata" to "[LoopVersioning] Annotate versioned loop with noalias metadata".
anemet updated the summary for this revision.
anemet added a comment.

More testing revealed that the vectorizer part of this patch is incorrect.

It annotated the loop *before* versioning so the scalar loop also carried
these annotations.  This is incorrect because we bail to the scalar loop if
the memchecks fail.

So I will add LoopVectorizer support for this separately in a follow-on patch.
I will also include a testcase for the above bug.

Also updating the title and the description accordingly.


http://reviews.llvm.org/D16712

Files:
  include/llvm/Transforms/Utils/LoopVersioning.h
  lib/Transforms/Scalar/LoopDistribute.cpp
  lib/Transforms/Utils/LoopVersioning.cpp
  test/Transforms/LoopVersioning/noalias-version-twice.ll
  test/Transforms/LoopVersioning/noalias.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16712.46682.patch
Type: text/x-patch
Size: 11750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160202/7a51e511/attachment.bin>


More information about the llvm-commits mailing list