[PATCH] D15644: [asan] Use private aliases for global variables (compiler-rt part).
Alexey Samsonov via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 2 10:35:15 PST 2016
samsonov added a comment.
Sorry for the delays. Overall, this looks good. However, please note that this is an ABI-breaking change: you will need to update asan_init_version.h
================
Comment at: lib/asan/asan_interface_internal.h:49
@@ -49,1 +48,3 @@
+ uptr beg; // The private address of the global.
+ uptr odr_indicator; // The address of the ODR indicator symbol.
uptr size; // The original size of the global.
----------------
Out of curiosity - why not make this new field last in the __asan_global structure?
Repository:
rL LLVM
http://reviews.llvm.org/D15644
More information about the llvm-commits
mailing list