[llvm] r259432 - [LVI] Remove overly tight assert from 259429

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 15:21:12 PST 2016


Author: reames
Date: Mon Feb  1 17:21:11 2016
New Revision: 259432

URL: http://llvm.org/viewvc/llvm-project?rev=259432&view=rev
Log:
[LVI] Remove overly tight assert from 259429

I'll submit a test case shortly which covers this, but it's causing clang self host problems in the builders so I wanted to get it removed.


Modified:
    llvm/trunk/lib/Analysis/LazyValueInfo.cpp

Modified: llvm/trunk/lib/Analysis/LazyValueInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=259432&r1=259431&r2=259432&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/LazyValueInfo.cpp (original)
+++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp Mon Feb  1 17:21:11 2016
@@ -853,7 +853,6 @@ bool LazyValueInfoCache::solveBlockValue
   LVILatticeVal Result;  // Start Undefined.
   Result.mergeIn(TrueVal, DL);
   Result.mergeIn(FalseVal, DL);
-  assert(!Result.isOverdefined() && "Should have exited previously");
   BBLV = Result;
   return true;
 }
@@ -984,7 +983,8 @@ bool getValueFromFromCondition(Value *Va
 }
 
 /// \brief Compute the value of Val on the edge BBFrom -> BBTo. Returns false if
-/// Val is not constrained on the edge.
+/// Val is not constrained on the edge.  Result is unspecified if return value
+/// is false.
 static bool getEdgeValueLocal(Value *Val, BasicBlock *BBFrom,
                               BasicBlock *BBTo, LVILatticeVal &Result) {
   // TODO: Handle more complex conditionals. If (v == 0 || v2 < 1) is false, we




More information about the llvm-commits mailing list