[PATCH] D16685: [tsan] Add a libc++ and lit testsuite for each ${TSAN_SUPPORTED_ARCH}.

[Alexey Samsonov via llvm-commits]

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

Sorry for delay. LGTM. Thank you for taking care of this!


================
Comment at: cmake/Modules/AddCompilerRT.cmake:301
@@ -300,2 +300,3 @@
                -DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR>
+               -DLLVM_PATH=${LLVM_SOURCE_DIR}
     LOG_BUILD 1
----------------
Please commit these changes separately, from http://reviews.llvm.org/D16681

================
Comment at: lib/tsan/CMakeLists.txt:207
@@ -206,5 +206,3 @@
    COMPILER_RT_TEST_COMPILER_ID STREQUAL "Clang")
-  set(LIBCXX_PREFIX ${CMAKE_CURRENT_BINARY_DIR}/libcxx_tsan)
-  add_custom_libcxx(libcxx_tsan ${LIBCXX_PREFIX}
-    DEPS ${TSAN_RUNTIME_LIBRARIES}
-    CFLAGS -fsanitize=thread)
+  set(dependencies)
+  foreach(arch ${TSAN_SUPPORTED_ARCH})
----------------
s/dependencies/libcxx_tsan_deps ?

================
Comment at: test/tsan/lit.cfg:44
@@ +43,3 @@
+                      "-Wall",
+                      "-m64"] +
+                      [config.target_cflags] +
----------------
dsanders wrote:
> I don't think this -m64 is needed now that we have config.target_cflags. Do you agree?
Yes


http://reviews.llvm.org/D16685