[PATCH] D16691: [InstCombine] simplify masked load intrinsics with constant masks

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 30 23:38:17 PST 2016


delena added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:678
@@ -677,1 +677,3 @@
 
+static Value *simplifyMaskedLoad(const IntrinsicInst &II,
+                                 InstCombiner::BuilderTy &Builder) {
----------------
Verifier checks intrinsic signature. You don't need these checks at all. 

================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:840
@@ +839,3 @@
+  // case Intrinsic::masked_store:
+  // case Intrinsic::masked_gather:
+  // case Intrinsic::masked_scatter:
----------------
Not sure that you can handle masked gather/scatter this way.


http://reviews.llvm.org/D16691





More information about the llvm-commits mailing list