[llvm] r259314 - No need to use utostr/utohexstr when writing into a raw_ostream. NFC
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 30 17:55:15 PST 2016
Author: ctopper
Date: Sat Jan 30 19:55:15 2016
New Revision: 259314
URL: http://llvm.org/viewvc/llvm-project?rev=259314&view=rev
Log:
No need to use utostr/utohexstr when writing into a raw_ostream. NFC
Modified:
llvm/trunk/utils/TableGen/FixedLenDecoderEmitter.cpp
Modified: llvm/trunk/utils/TableGen/FixedLenDecoderEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/FixedLenDecoderEmitter.cpp?rev=259314&r1=259313&r2=259314&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/FixedLenDecoderEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/FixedLenDecoderEmitter.cpp Sat Jan 30 19:55:15 2016
@@ -732,15 +732,15 @@ void FixedLenDecoderEmitter::emitTable(f
OS.indent(Indentation) << "MCD::OPC_FilterValue, ";
// The filter value is ULEB128 encoded.
while (*I >= 128)
- OS << utostr(*I++) << ", ";
- OS << utostr(*I++) << ", ";
+ OS << (unsigned)*I++ << ", ";
+ OS << (unsigned)*I++ << ", ";
// 16-bit numtoskip value.
uint8_t Byte = *I++;
uint32_t NumToSkip = Byte;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
Byte = *I++;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
NumToSkip |= Byte << 8;
OS << "// Skip to: " << ((I - Table.begin()) + NumToSkip) << "\n";
break;
@@ -753,14 +753,14 @@ void FixedLenDecoderEmitter::emitTable(f
<< Len << ", ";// << Val << ", " << NumToSkip << ",\n";
// ULEB128 encoded field value.
for (; *I >= 128; ++I)
- OS << utostr(*I) << ", ";
- OS << utostr(*I++) << ", ";
+ OS << (unsigned)*I << ", ";
+ OS << (unsigned)*I++ << ", ";
// 16-bit numtoskip value.
uint8_t Byte = *I++;
uint32_t NumToSkip = Byte;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
Byte = *I++;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
NumToSkip |= Byte << 8;
OS << "// Skip to: " << ((I - Table.begin()) + NumToSkip) << "\n";
break;
@@ -769,15 +769,15 @@ void FixedLenDecoderEmitter::emitTable(f
++I;
OS.indent(Indentation) << "MCD::OPC_CheckPredicate, ";
for (; *I >= 128; ++I)
- OS << utostr(*I) << ", ";
- OS << utostr(*I++) << ", ";
+ OS << (unsigned)*I << ", ";
+ OS << (unsigned)*I++ << ", ";
// 16-bit numtoskip value.
uint8_t Byte = *I++;
uint32_t NumToSkip = Byte;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
Byte = *I++;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
NumToSkip |= Byte << 8;
OS << "// Skip to: " << ((I - Table.begin()) + NumToSkip) << "\n";
break;
@@ -796,13 +796,13 @@ void FixedLenDecoderEmitter::emitTable(f
OS.indent(Indentation) << "MCD::OPC_" << (IsTry ? "Try" : "")
<< "Decode, ";
for (p = Buffer; *p >= 128; ++p)
- OS << utostr(*p) << ", ";
- OS << utostr(*p) << ", ";
+ OS << (unsigned)*p << ", ";
+ OS << (unsigned)*p << ", ";
// Decoder index.
for (; *I >= 128; ++I)
- OS << utostr(*I) << ", ";
- OS << utostr(*I++) << ", ";
+ OS << (unsigned)*I << ", ";
+ OS << (unsigned)*I++ << ", ";
if (!IsTry) {
OS << "// Opcode: "
@@ -815,9 +815,9 @@ void FixedLenDecoderEmitter::emitTable(f
// 16-bit numtoskip value.
uint8_t Byte = *I++;
uint32_t NumToSkip = Byte;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
Byte = *I++;
- OS << utostr(Byte) << ", ";
+ OS << (unsigned)Byte << ", ";
NumToSkip |= Byte << 8;
OS << "// Opcode: "
@@ -832,22 +832,28 @@ void FixedLenDecoderEmitter::emitTable(f
uint64_t Value = 0;
unsigned Shift = 0;
do {
- OS << ", " << utostr(*I);
+ OS << ", " << (unsigned)*I;
Value += (*I & 0x7f) << Shift;
Shift += 7;
} while (*I++ >= 128);
- if (Value > 127)
- OS << " /* 0x" << utohexstr(Value) << " */";
+ if (Value > 127) {
+ OS << " /* 0x";
+ OS.write_hex(Value);
+ OS << " */";
+ }
// Negative mask
Value = 0;
Shift = 0;
do {
- OS << ", " << utostr(*I);
+ OS << ", " << (unsigned)*I;
Value += (*I & 0x7f) << Shift;
Shift += 7;
} while (*I++ >= 128);
- if (Value > 127)
- OS << " /* 0x" << utohexstr(Value) << " */";
+ if (Value > 127) {
+ OS << " /* 0x";
+ OS.write_hex(Value);
+ OS << " */";
+ }
OS << ",\n";
break;
}
More information about the llvm-commits
mailing list