[PATCH] D16648: ELF: Find invalid relocations as many as possible.

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with a testcase and a few nits.


================
Comment at: ELF/Target.cpp:447
@@ -446,3 +446,3 @@
   default:
-    fatal("unrecognized reloc " + Twine(Type));
+    error("unrecognized reloc " + Twine(Type));
   }
----------------
This is a broken file.

================
Comment at: ELF/Target.cpp:906
@@ -905,3 +905,3 @@
   default:
-    fatal("unrecognized reloc " + Twine(Type));
+    error("unrecognized reloc " + Twine(Type));
   }
----------------
This is a broken file.

================
Comment at: ELF/Target.cpp:936
@@ -935,3 +935,3 @@
   default:
-    fatal("unrecognized reloc " + Twine(Type));
+    error("unrecognized reloc " + Twine(Type));
   }
----------------
This is a broken file.

================
Comment at: ELF/Target.cpp:1144
@@ -1143,3 +1143,3 @@
   default:
-    fatal("unrecognized reloc " + Twine(Type));
+    error("unrecognized reloc " + Twine(Type));
   }
----------------
This is a broken file.

================
Comment at: ELF/Target.cpp:1381
@@ -1378,3 +1380,3 @@
   default:
-    fatal("unrecognized reloc " + Twine(Type));
+    error("unrecognized reloc " + Twine(Type));
   }
----------------
This is a broken file.

================
Comment at: ELF/Target.cpp:1523
@@ -1518,3 +1522,3 @@
   default:
-    fatal("unrecognized reloc " + Twine(Type));
+    error("unrecognized reloc " + Twine(Type));
   }
----------------
This is a broken file.


http://reviews.llvm.org/D16648