[llvm-dev] [llvm] r259255 - Need #include <cstdint> for uint64_t

[Justin Bogner via llvm-commits]

Sean Silva via llvm-commits <llvm-commits at lists.llvm.org> writes:
> On Fri, Jan 29, 2016 at 6:27 PM, Matthias Braun via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>     The point I was trying to make here is that all things that DataTypes.h
>     provides:
>     intXXX_t, uintXX_t, PRIdXX, INT64_MAX, HUGE_VAL, ssize_t ...
>     are all part of the C++11 standard and can be found in <cstdint>, <cmath>
>     (except for ssize_t) so I wondered if there is still a need for llvm to
>     provide this header since we require a C++11 compiler anyway nowadays.
>
> FWIW, I've thought about this too. cstdint and stdint.h are C++11, and I think
> that MSVC claims to support them. Maybe the next time that we bump up MSVC
> version it will work.

MSDN claims that VS2013 has cinttypes, so we can probably get rid of
DataTypes.h now if we want to. I guess something like the attached patch
probably does the trick, but maybe other LLVM subprojects still use the
header.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-datatypes.patch
Type: text/x-patch
Size: 80588 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160129/9d3382a2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-datatypes-clang.patch
Type: text/x-patch
Size: 9039 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160129/9d3382a2/attachment-0001.bin>