[PATCH] D16730: [PGO] cc1 option names change for profile instrumentation (NFC)

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 19:04:25 PST 2016


davidxl added inline comments.

================
Comment at: test/Profile/c-generate.c:4
@@ +3,3 @@
+// RUN: %clang %s -S -o - -emit-llvm -Xclang -fprofile-instrument=none -fprofile-generate | FileCheck %s --check-prefix=PROF-INSTR-NONE
+// RUN: not %clang %s -S -o - -emit-llvm -Xclang -fprofile-instrument=garbage -fprofile-generate |& FileCheck %s --check-prefix=PROF-INSTR-GARBAGE
+//
----------------
silvas wrote:
> `|&` doesn't seem to be used in other tests inside clang and llvm. A more portable alternative is probably required to pass the bots.
Should be safe to use 2>&1 | FileCheck -- there are existing test cases ..


http://reviews.llvm.org/D16730





More information about the llvm-commits mailing list