[PATCH] D16730: [PGO] cc1 option names change for profile instrumentation (NFC)

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: test/Profile/c-generate.c:3
@@ +2,3 @@
+// RUN: %clang_cc1 -main-file-name c-generate.c %s -o - -emit-llvm -fprofile-instrument=clang -fprofile-instrument-path=c-generate-test.profraw | FileCheck %s --check-prefix=PROF-INSTR-PATH
+// RUN: %clang %s -S -o - -emit-llvm -Xclang -fprofile-instrument=none -fprofile-generate | FileCheck %s --check-prefix=PROF-INSTR-NONE
+// RUN: not %clang %s -S -o - -emit-llvm -Xclang -fprofile-instrument=garbage -fprofile-generate |& FileCheck %s --check-prefix=PROF-INSTR-GARBAGE
----------------
Why are you not using `%clang_cc1` consistently here?

================
Comment at: test/Profile/c-generate.c:4
@@ +3,3 @@
+// RUN: %clang %s -S -o - -emit-llvm -Xclang -fprofile-instrument=none -fprofile-generate | FileCheck %s --check-prefix=PROF-INSTR-NONE
+// RUN: not %clang %s -S -o - -emit-llvm -Xclang -fprofile-instrument=garbage -fprofile-generate |& FileCheck %s --check-prefix=PROF-INSTR-GARBAGE
+//
----------------
`|&` doesn't seem to be used in other tests inside clang and llvm. A more portable alternative is probably required to pass the bots.


http://reviews.llvm.org/D16730