[PATCH] D16742: [DWARFDebug] Fix another case of overlapping ranges

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 16:24:21 PST 2016


aprantl added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:821
@@ +820,3 @@
+    for (auto &Value : Values)
+      for (auto &NextValue : Next.Values)
+        if (piecesOverlap(cast_or_null<DIExpression>(Value.Expression),
----------------
Do we have to do n^2 comparisons? I vaguely remember the pieces being sorted by offset. Or was this only later?


Repository:
  rL LLVM

http://reviews.llvm.org/D16742





More information about the llvm-commits mailing list