[PATCH] D16723: [AMDGPU] Disassembler: Added basic disassembler for AMDGPU target.

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/Disassembler/LLVMBuild.txt:1
@@ +1,2 @@
+;===- ./lib/Target/AArch64/Disassembler/LLVMBuild.txt ------------*- Conf -*--===;
+;
----------------
Copy and paste error: s/AArch64/AMDGPU/

================
Comment at: lib/Target/AMDGPU/Disassembler/Makefile:1
@@ +1,2 @@
+##===- lib/Target/AArch64/Disassembler/Makefile ------------*- Makefile -*-===##
+#
----------------
Makefiles have been deleted, so you don't need to update this file.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:3017
@@ -2928,2 +3016,3 @@
 
+//include "PseudoInstructions.td"
 include "SIInstructions.td"
----------------
This can be removed.

================
Comment at: utils/TableGen/FixedLenDecoderEmitter.cpp:1733
@@ -1732,2 +1732,3 @@
   std::string InstDecoder = Def.getValueAsString("DecoderMethod");
+  if (InstDecoder == "NONE") return false;
   if (InstDecoder != "") {
----------------
This change needs to be in a separate patch.


http://reviews.llvm.org/D16723