[PATCH] D16611: Fix CombineToPreIndexedLoadStore O(n^2) behavior

[Tim Shen via llvm-commits]

timshen marked 6 inline comments as done.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9614
@@ -9609,4 +9613,3 @@
 
-      if (Use.getUser()->isPredecessorOf(N))
-        continue;
+      if (N->hasPredecessorHelper(Use.getUser(), Visited, Worklist)) continue;
 
----------------
majnemer wrote:
> Please format this with clang-format
I was using a very old version. Re-formanted using trunk version. Thanks!

================
Comment at: test/CodeGen/PowerPC/combine-to-pre-index-store-crash.ll:1
@@ +1,2 @@
+; RUN: llc < %s
+target datalayout = "e-m:e-i64:64-n32:64"
----------------
majnemer wrote:
> No FileCheck lines?
Yes, the error is a crash, as the file name indicates


http://reviews.llvm.org/D16611