[PATCH] D16038: [LCG] Build an edge abstraction for the LazyCallGraph and use it to differentiate between indirect references to functions an direct calls.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 17:13:40 PST 2016


echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.

LGTM as well (other than the things Philip brings up inline and one of my own inline).

Thanks!

-eric


================
Comment at: lib/Analysis/LazyCallGraph.cpp:74
@@ +73,3 @@
+  // are trivially added, but to accumulate the latter we walk the instructions
+  // and add every operand which is a constant to the worklist to process
+  // afterward.
----------------
s/constant/"direct call" perhaps?


http://reviews.llvm.org/D16038





More information about the llvm-commits mailing list