[PATCH] D16643: ELF: Report more than one undefined symbols if exist.
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 28 09:23:05 PST 2016
rafael added inline comments.
================
Comment at: ELF/Writer.cpp:425
@@ -423,2 +424,3 @@
ErrorOr<StringRef> SymNameOrErr = Sym.getName(F->getStringTable());
- fatal(SymNameOrErr);
+ if (!SymNameOrErr) {
+ error(SymNameOrErr);
----------------
I don't think this is related to this patch. This error is about a broken st_name, not about a user error.
================
Comment at: ELF/Writer.cpp:897
@@ -892,1 +896,3 @@
+ if (HasError)
+ return false;
----------------
Please move this just before addCommonSymbols.
http://reviews.llvm.org/D16643
More information about the llvm-commits
mailing list