[PATCH] D16685: [tsan] Add a libc++ and lit testsuite for each ${TSAN_SUPPORTED_ARCH}.

[Daniel Sanders via llvm-commits]

dsanders added a comment.

There's a couple things about this patch that I'd like to mention


================
Comment at: test/tsan/CMakeLists.txt:21-25
@@ +20,7 @@
+  string(TOLOWER "-${arch}" TSAN_TEST_CONFIG_SUFFIX)
+  if(ANDROID OR ${arch} MATCHES "arm|aarch64")
+    # This is only true if we are cross-compiling.
+    # Build all tests with host compiler and use host tools.
+    set(TSAN_TEST_TARGET_CC ${COMPILER_RT_TEST_COMPILER})
+    set(TSAN_TEST_TARGET_CFLAGS ${COMPILER_RT_TEST_COMPILER_CFLAGS})
+  else()
----------------
This check is duplicated from the equivalent code in asan and it looks a little odd to me. It makes sense to me that ANDROID is only true for cross-compilation but the '${arch} MATCHES "arm|aarch64"' can be true on native builds despite the comment saying it's only true for cross-compilation.

================
Comment at: test/tsan/lit.cfg:44
@@ +43,3 @@
+                      "-Wall",
+                      "-m64"] +
+                      [config.target_cflags] +
----------------
I don't think this -m64 is needed now that we have config.target_cflags. Do you agree?


http://reviews.llvm.org/D16685