[PATCH] D16684: [ARM] Emit trap instruction using .inst directive

[Alexandros Lamprineas via llvm-commits]

labrinea added inline comments.

================
Comment at: test/CodeGen/ARM/debugtrap.ll:13
@@ -12,3 +12,3 @@
   ; CHECK-NEXT: pop
-  ; CHECK-NEXT: trap
   call void @foo()
----------------
Not sure why was this valid. "trap" was present only in a comment: '@ trap'

================
Comment at: test/CodeGen/ARM/trap.ll:4
@@ -3,3 +3,1 @@
 ; RUN: llc < %s -mtriple=arm-apple-darwin -trap-func=_trap -O0 | FileCheck %s -check-prefix=FUNC
-; RUN: llc -mtriple=armv7-unknown-nacl -filetype=obj %s -o - \
-; RUN:  | llvm-objdump -disassemble -triple armv7-unknown-nacl - \
----------------
We shouldn't be testing -mtriple=armv7-unknown-nacl in CodeGen, it is a Clang thing. -mattr=+nacl-trap is the right thing to test in the back-end.


http://reviews.llvm.org/D16684