[zorg] r259032 - [zorg] Correct CMAKE_BUILD_TYPE in getLLVMCMakeBuildFactory.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 01:38:18 PST 2016


Author: dsanders
Date: Thu Jan 28 03:38:18 2016
New Revision: 259032

URL: http://llvm.org/viewvc/llvm-project?rev=259032&view=rev
Log:
[zorg] Correct CMAKE_BUILD_TYPE in getLLVMCMakeBuildFactory.

A stray comma meant it was extending the cmake_args list with a 1-element tuple
containing a list containing '-DCMAKE_BUILD_TYPE=...'.

Surprisingly, cmake doesn't fail when you give it
"['-DCMAKE_BUILD_TYPE=Release']" as an argument.

Modified:
    zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py

Modified: zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py?rev=259032&r1=259031&r2=259032&view=diff
==============================================================================
--- zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py (original)
+++ zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py Thu Jan 28 03:38:18 2016
@@ -178,7 +178,7 @@ def getLLVMCMakeBuildFactory(
             workdir       = llvm_srcdir))
 
     cmake_args = ['cmake']
-    cmake_args += ["-DCMAKE_BUILD_TYPE="+config_name],
+    cmake_args += ["-DCMAKE_BUILD_TYPE="+config_name]
     if enable_shared:
         cmake_args.append('-DBUILD_SHARED_LIBS=ON')
     cmake_args.extend(extra_cmake_args)




More information about the llvm-commits mailing list