[PATCH] D16654: using /system/bin/sh on android in tests.

[Evgeniy Stepanov via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM w/ a nit


================
Comment at: lib/sanitizer_common/tests/sanitizer_linux_test.cc:269
@@ -268,4 +268,3 @@
   ASSERT_EQ(0, pipe(pipe_fds));
-  const char *argv[] = {"/bin/sh", "-c", "echo -n 'hello'"};
-  int pid = StartSubprocess("/bin/sh", const_cast<char **>(&argv[0]),
-                            kInvalidFd /* stdin */, pipe_fds[1] /* stdout */);
+#if !SANITIZER_ANDROID
+  const char *shell = "/bin/sh";
----------------
please invert the condition


http://reviews.llvm.org/D16654