[PATCH] D16374: [sancov] generating html report on coverage dump

[Mike Aizatsky via llvm-commits]

aizatsky added inline comments.

================
Comment at: test/asan/TestCases/Posix/coverage_html_report.cc:6
@@ +5,3 @@
+// RUN: cd %T/coverage_html_report
+// RUN: %env_asan_opts=coverage=1:verbosity=1:html_cov_report=1:sancov=%sancovcc %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-main
+// RUN: ls *.html | FileCheck %s --check-prefix=CHECK-ls
----------------
samsonov wrote:
> Will this test work even if you don't provide sancov=%sancovcc explicitly?
it does

================
Comment at: test/asan/TestCases/Posix/coverage_html_report.cc:24
@@ +23,2 @@
+// CHECK-main: html report generated to ./coverage_html_report.cc.tmp.[[PID]].html
+// CHECK-ls: coverage_html_report.cc.tmp.{{[0-9]+}}.html
----------------
samsonov wrote:
> Should this also be [[PID]].html ?
It's a different invocation of FileCheck. Unfortunately PID is not available here.


http://reviews.llvm.org/D16374