[PATCH] D16641: ELF: Rename error -> fatal and redefine error as a non-noreturn function.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 11:23:53 PST 2016


Eventually I think it'll probably be good/necessary to have a "linking
context" (for things like "HasError", and more likely a blob of diagnostic
info and/or a callback for reporting diagnostics) rather than global (or
even TLS) variables. But for sure this seems like one of many good
incremental steps, many of them orthogonal (indeed a global context could
be introduced in parallel with this patch for other reasons, etc, then the
flag moved over later)

Great to see small/incremental pieces like this when tackling such a large
problem!

- Dave

On Wed, Jan 27, 2016 at 11:15 AM, Rui Ueyama via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> ruiu updated this revision to Diff 46159.
> ruiu added a comment.
>
> - Remove an unrelated file.
>
>
> http://reviews.llvm.org/D16641
>
> Files:
>   ELF/Driver.cpp
>   ELF/Driver.h
>   ELF/DriverUtils.cpp
>   ELF/Error.cpp
>   ELF/Error.h
>   ELF/InputFiles.cpp
>   ELF/InputSection.cpp
>   ELF/LinkerScript.cpp
>   ELF/OutputSections.cpp
>   ELF/SymbolTable.cpp
>   ELF/Target.cpp
>   ELF/Writer.cpp
>   include/lld/Driver/Driver.h
>   lib/Driver/UniversalDriver.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160127/0fa4b61e/attachment.html>


More information about the llvm-commits mailing list