[PATCH] D16599: ELF: Define another entry point.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 19:06:50 PST 2016


davide added inline comments.

================
Comment at: ELF/DriverUtils.cpp:128
@@ +127,3 @@
+  // (P just needs to be some symbol in the binary.)
+  void *P = (void *)(intptr_t)getLldExecutable;
+  SmallString<128> Dir;
----------------
ruiu wrote:
> davide wrote:
> > The double cast is not exactly pretty, but I'm not exactly sure there's a way to avoid it.
> I took this line from Clang. We may be able to remove (intptr_t), and just do (void *).
Fair enough, assuming GCC or clang don't complain


http://reviews.llvm.org/D16599





More information about the llvm-commits mailing list