[PATCH] D16611: Fix CombineToPreIndexedLoadStore O(n^2) behavior
Kyle Butt via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 26 16:27:45 PST 2016
iteratee added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9596
@@ -9595,1 +9595,3 @@
+ // Caches for hasPredecessorHelper
+ SmallPtrSet<const SDNode *, 32> Visited;
----------------
Can you add a const annotation to N so that this is obviously correct?
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6937
@@ -6936,3 +6936,3 @@
bool
SDNode::hasPredecessorHelper(const SDNode *N,
----------------
Can you add some header comments for hasPredecessorHelper while you're here?
http://reviews.llvm.org/D16611
More information about the llvm-commits
mailing list