[PATCH] D16604: Disable all standard lib functions for NVVM.

[Justin Lebar via llvm-commits]

jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: hfinkel, llvm-commits, jhen, echristo.

NVVM doesn't have a standard library, as currently implemented, so this
just isn't going to work.  I'd like to revisit this, since it's hiding
opportunities for optimization, but correctness comes first.

Thank you to hfinkel for pointing me in the right direction here.

http://reviews.llvm.org/D16604

Files:
  lib/Analysis/TargetLibraryInfo.cpp

Index: lib/Analysis/TargetLibraryInfo.cpp
===================================================================
--- lib/Analysis/TargetLibraryInfo.cpp
+++ lib/Analysis/TargetLibraryInfo.cpp
@@ -385,6 +385,20 @@
     TLI.setUnavailable(LibFunc::tmpfile64);
   }
 
+  // As currently implemented in clang, NVPTX code has no standard library to
+  // speak of.  Headers provide a standard-ish library implementation, but many
+  // of the signatures are wrong -- for example, many libm functions are not
+  // extern "C".
+  //
+  // libdevice, an IR library provided by nvidia, is linked in by the front-end,
+  // but only used functions are provided to llvm.  Moreover, most of the
+  // functions in libdevice don't map precisely to standard library functions.
+  //
+  // FIXME: Having no standard library prevents e.g. many fastmath
+  // optimizations, so this situation should be fixed.
+  if (T.isNVPTX())
+    TLI.disableAllFunctions();
+
   TLI.addVectorizableFunctionsFromVecLib(ClVectorLibrary);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16604.46057.patch
Type: text/x-patch
Size: 1009 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160126/298e4116/attachment.bin>