[PATCH] D16585: In split module utility we should never separate alias with its aliasee.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.

================
Comment at: lib/Transforms/Utils/SplitModule.cpp:95
@@ +94,3 @@
+      if (const GlobalObject *Base = GA->getBaseObject())
+        GVtoClusterMap.unionSets(&GV, cast<GlobalValue>(Base));
+    }
----------------
You no longer need this cast.

================
Comment at: test/tools/llvm-split/scc-global-alias.ll:22
@@ +21,3 @@
+ at funInternal2Alias = alias i32 (), i32 ()* @funInternal2
+ at funExternal2Alias = alias i32 (), i32 ()* @funExternal2
+
----------------
Please add a test case with a non-`GlobalValue` constant.


http://reviews.llvm.org/D16585