[PATCH] D15728: [cfi] Support for dlopen and dlclose

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 16:24:38 PST 2016


eugenis added inline comments.

================
Comment at: lib/cfi/cfi.cc:140
@@ +139,3 @@
+  if (main_shadow) {
+    void *res = mremap((void *)shadow_, __cfi_shadow_size, __cfi_shadow_size,
+                       MREMAP_MAYMOVE | MREMAP_FIXED, main_shadow);
----------------
pcc wrote:
> Do you need to set the memory protection for `shadow_` first?
Of course.
Good catch.



Repository:
  rL LLVM

http://reviews.llvm.org/D15728





More information about the llvm-commits mailing list