[PATCH] D15660: [cfi] Cross-DSO CFI diagnostic mode (llvm part)

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 13:58:09 PST 2016


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Transforms/IPO/CrossDSOCFI.cpp:134
@@ +133,3 @@
+      Type::getInt8PtrTy(Ctx), nullptr);
+  assert(CFICheckFailFn || "Module is missing a __cfi_check_fail function");
+  IRBFail.CreateCall(CFICheckFailFn, {&CFICheckFailData, &Addr});
----------------
You no longer need to assert here.


Repository:
  rL LLVM

http://reviews.llvm.org/D15660





More information about the llvm-commits mailing list