[PATCH] D16540: Avoid almost duplication in .dynamic finalize and write.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 11:54:50 PST 2016


ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:713-723
@@ -691,13 +712,13 @@
 
   auto WritePtr = [&](int32_t Tag, uint64_t Val) {
     P->d_tag = Tag;
     P->d_un.d_ptr = Val;
     ++P;
   };
 
   auto WriteVal = [&](int32_t Tag, uint32_t Val) {
     P->d_tag = Tag;
     P->d_un.d_val = Val;
     ++P;
   };
 
----------------
These helper functions don't make sense any more. You can inline them.


http://reviews.llvm.org/D16540





More information about the llvm-commits mailing list