[PATCH] D16532: Make runtime/test/barrier/omp_barrier.c pass on 2-core machines

Andrey Churbanov via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 09:02:21 PST 2016


AndreyChurbanov added a comment.

Suggested change does not fix the test reliably, because it will still fail on a single processor machine.

I am sorry if I broken some rules here, but I have committed more reliable fix for the test (revision #258695) so that
(1) it now passes on any number of processors, and (2) it runs in 1 sec instead of in 10 sec in initial implementation.

I don't think it makes much sense to have threads to spin 10 times per 1 sec in order to check the barrier, much smaller delay is perfectly enough (I've reduced it to 10 x 0.1 sec).

Feel free to comment.
Thanks, Andrey.


Repository:
  rL LLVM

http://reviews.llvm.org/D16532





More information about the llvm-commits mailing list