[PATCH] D15784: Enable 2 warnings on MSVC, turn on StringPooling & intrinsic functions

[Aaron Ballman via llvm-commits]

aaron.ballman added a comment.

LGTM again, so I have commit as r258687.


================
Comment at: C:/LLVM/llvm/cmake/modules/HandleLLVMOptions.cmake:366
@@ -365,1 +365,3 @@
 
+  # /Zc:strictStrings is incompatible with VS12's (Visual Studio 2013's)
+  # debug mode headers. Instead of only enabling them in VS2013's debug mode,
----------------
> I presume it is not forward compatible. I'm also not sure how I'd enable strictStrings in a forwards compatible way.

I think that the way you've done it here is the best we can do.


http://reviews.llvm.org/D15784