[llvm] r258666 - [Object][COFF] Revert r258665 - It doesn't do what I had intended.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 24 17:21:46 PST 2016


Author: lhames
Date: Sun Jan 24 19:21:45 2016
New Revision: 258666

URL: http://llvm.org/viewvc/llvm-project?rev=258666&view=rev
Log:
[Object][COFF] Revert r258665 - It doesn't do what I had intended.

I'm discussing the right approach for tracking visibility for COFF symbols on
the llvm-dev list.


Modified:
    llvm/trunk/lib/Object/COFFObjectFile.cpp

Modified: llvm/trunk/lib/Object/COFFObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/COFFObjectFile.cpp?rev=258666&r1=258665&r2=258666&view=diff
==============================================================================
--- llvm/trunk/lib/Object/COFFObjectFile.cpp (original)
+++ llvm/trunk/lib/Object/COFFObjectFile.cpp Sun Jan 24 19:21:45 2016
@@ -207,7 +207,7 @@ uint32_t COFFObjectFile::getSymbolFlags(
   uint32_t Result = SymbolRef::SF_None;
 
   if (Symb.isExternal() || Symb.isWeakExternal())
-    Result |= (SymbolRef::SF_Global | SymbolRef::SF_Exported);
+    Result |= SymbolRef::SF_Global;
 
   if (Symb.isWeakExternal())
     Result |= SymbolRef::SF_Weak;




More information about the llvm-commits mailing list