[PATCH] D16509: [DebugInfo] Fix DWARFDebugFrame instruction operand ordering

[David Blaikie via llvm-commits]

dblaikie added a subscriber: dblaikie.
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, with one suggested change. Thanks!


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:168
@@ +167,3 @@
+          // for arguments is unspecified.
+          uint64_t op1, op2;
+          op1 = Data.getULEB128(Offset);
----------------
Roll the declaration/initialization together:

  auto op1 = Data.getULEB128(Offset);
  auto op2 = Data.getULEB128(Offset);

(using auto is optional - whichever you prefer - but the type information doesn't seem that important (given that the origintal formulation of this code didn't provide explicit type information to the reader))


http://reviews.llvm.org/D16509