[PATCH] D16428: [CMake] Provide options for toggling on and off various runtime libraries.

[Alexey Samsonov via llvm-commits]

samsonov added inline comments.

================
Comment at: cmake/config-ix.cmake:655
@@ -639,3 +654,3 @@
 
 if (COMPILER_RT_HAS_SANITIZER_COMMON AND CFI_SUPPORTED_ARCH AND
     OS_NAME MATCHES "Linux")
----------------
Hm, do you need to remove/update this now?

================
Comment at: lib/CMakeLists.txt:17
@@ +16,3 @@
+  endforeach()
+  check_list_contains(COMPILER_RT_HAS_COMMON COMPILER_RT_RUNTIMES_TO_BUILD sanitizer_common)
+  
----------------
Looks like you have to pepper these `check_list_contains` code around the CMakeLists.txt now. WDYT of generating them in a single place
in config-ix.cmake, and using them as is?

  foreach(runtime ${COMPILER_RT_RUNTIMES_TO_BUILD})
    string(TOUPPER ${runtime} runtime_toupper)
    set(COMPILER_RT_HAS_${runtime_toupper} True)
  endforeach()

?


http://reviews.llvm.org/D16428