[PATCH] D11393: [X86] Allow X86::COND_NE_OR_P and X86::COND_NP_OR_E to be reversed.

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4062
@@ -4039,3 +4061,3 @@
       return true;
 
     // Update the MachineOperand.
----------------
Should these two JCCs be eliminated?

================
Comment at: test/CodeGen/X86/block-placement.ll:671
@@ -669,4 +670,3 @@
 ; CHECK: %entry
-; CHECK: %foo
 ; CHECK: %bar
 ; CHECK: %exit
----------------
Ok -- you are right.

================
Comment at: test/CodeGen/X86/fp-une-cmp.ll:49
@@ +48,3 @@
+; CHECK-NEXT:  jp  [[LABEL]]
+; CHECK:       jmp
+;
----------------
The branch sequence does imply  BB2 is reordered before BB1. Is it better to explicit test the label order?

Also why is the jump sequence not the optimal one:

jne bb2
jnp bb1
bb2:
bb1:


http://reviews.llvm.org/D11393