[PATCH] D11393: [X86] Allow X86::COND_NE_OR_P and X86::COND_NP_OR_E to be reversed.

Cong Hou via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 15:26:02 PST 2016


congh marked an inline comment as done.
congh added a comment.

In http://reviews.llvm.org/D11393#333833, @davidxl wrote:

> For the new suggested test case, I am thinking a code with
>
>   %cmp = fcmp une float %f, 0.000000e+00
>   br i1 %cmp, label %if.then, label %if.end
>   
>
> With the branch probably annotated with profile data to enable the reordering we want.


OK, I have added such a test case.


================
Comment at: test/CodeGen/X86/block-placement.ll:669
@@ -669,4 +668,3 @@
 ; CHECK: %entry
-; CHECK: %foo
 ; CHECK: %bar
 ; CHECK: %exit
----------------
I don't get it. What is the problem of the current CHECKs? I think the order of those four blocks is already enforced.


http://reviews.llvm.org/D11393





More information about the llvm-commits mailing list