[PATCH] D16405: [ELF] - Symbols from object files that override symbols in DSO are added to .dynsym table.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Symbols.cpp:56
@@ -55,1 +55,3 @@
 
+  if (isShared() != Other->isShared())
+    if (isa<DefinedRegular<ELFT>>(isShared() ? Other : this))
----------------
Let's add a comment.

  // We want to export all symbols that exist both in the executable
  // and in DSOs, so that the symbols in the executable can interrupt
  // symbols in the DSO at runtime.


http://reviews.llvm.org/D16405