Allowable characters in linker scripts

[Pete Cooper via llvm-commits]

Hi Rui, Rafael

I have a jenkins bot building lld.  Due to a plugin called ‘shared workspaces’ its common to have @’s in paths.

This bot is then failing on 3 ELF tests (ELF/as-needed.s, ELF/linkerscript.s, ELF/linkerscript2.s)

I’ve diagnosed the issue on linkerscript.s and its down to @ not being in the set of unquoted tokens in LinkerScript::tokenize.

I’d like to propose a patch, but first I’d like to double check what the preferred solution is.  I think its either:
- Add @ to the allowable characters in a token, or
- Change the test to quote the path

Which would you prefer?

Thanks,
Pete

PS, the linkerscipt.s script contains this entry which is the cause of the failure: "SEARCH_DIR( /Volumes/Data/apple-lld-stage1 at 2/build/tools/lld/test/ELF/Output/linkerscript2.s.tmp.dir )"