[PATCH] D16439: [PlaceSafepoints] Introduce a -spp-no-statepoints flag

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 12:42:13 PST 2016


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

With the explanation of overall direction, LGTM.

FYI, when you get back to switching the default, you'll need to port all the tests to the new output format.


================
Comment at: lib/Transforms/Scalar/PlaceSafepoints.cpp:670
@@ +669,3 @@
+
+  // If we've been asked to not wrap the calls with gc.statepoint, then we're
+  // done.
----------------
I would like to see a bit more context here.  In particular, we expect this to become the default, and that rs4gc will take over this responsibility.  


http://reviews.llvm.org/D16439





More information about the llvm-commits mailing list