[llvm] r257875 - [InstCombine] Rewrite bswap/bitreverse handling completely.

[Dimitry Andric via llvm-commits]

On 22 Jan 2016, at 19:31, Hans Wennborg <hans at chromium.org> wrote:
> 
> On Fri, Jan 22, 2016 at 7:50 AM, Ismail Donmez via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> On Fri, Jan 22, 2016 at 4:52 PM, James Molloy via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Hi,
>>> 
>>> Yes, r257886 needs to be merged also. This appeases the msan bots, and could explain your segfaults (although I didn’t see any segfaults myself! unless this is a stage2 build?)
>> 
>> Reverting rr258180 also fixed my stage2 builds, I'll try with r257886 later on.
> 
> Strange, I haven't been able to reproduce these test failures. I ran
> the release script on the tip of 3.8, both for x86_64 and i686. I
> didn't try running under msan, though.
> 
> Anyway, sounds like r257886 should be merged, so I've done that in
> r258510. Please let me know if that improves things.

Even before you merged this, I had hand-merged it locally, re-ran the build and the tests, and this indeed fixes all tests.  I also ran a few of the tests which failed previously under valgrind, and apart from a few innocuous "Conditional jump or move depends on uninitialised value(s)" messages, they are giving no errors anymore.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160122/c243822d/attachment.sig>