[PATCH] D16240: [InstCombine] Simplify a known nonzero incoming value of PHI

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 10:59:47 PST 2016


junbuml added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombinePHI.cpp:941
@@ +940,3 @@
+        Instruction *CtxI = (InBB && InBB->getTerminator())
+                                ? (Instruction *)InBB->getTerminator()
+                                : (Instruction *)&PN;
----------------
majnemer wrote:
> It will only be null for BasicBlocks which are newly created.  Your basic block will not be newly created, please remove the null check.
Thanks David. Removed the null check.


http://reviews.llvm.org/D16240





More information about the llvm-commits mailing list