[llvm] r258428 - [LibCallSimplifier] don't get fooled by a fake fmin()

[Hans Wennborg via llvm-commits]

It seems like a good fix, and since we're still relatively early in
the process, I'll take it.

Merged (together with r258416) in r258512.

Thanks,
Hans

On Thu, Jan 21, 2016 at 7:28 PM, Sanjay Patel <spatel at rotateright.com> wrote:
> I think the patch is safe, but this bug has probably existed for a long
> time. So it's a judgement call whether it should be merged to 3.8?
>
>
> On Thursday, January 21, 2016, Hans Wennborg <hans at chromium.org> wrote:
>>
>> Sanjay, it was pointed out by Joerg that this should probably also be
>> merged to 3.8?
>>
>> On Thu, Jan 21, 2016 at 12:19 PM, Sanjay Patel via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> > Author: spatel
>> > Date: Thu Jan 21 14:19:54 2016
>> > New Revision: 258428
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=258428&view=rev
>> > Log:
>> > [LibCallSimplifier] don't get fooled by a fake fmin()
>> >
>> > This is similar to the bug/fix:
>> > https://llvm.org/bugs/show_bug.cgi?id=26211
>> > http://reviews.llvm.org/rL258325
>> >
>> > The fmin() test case reveals another bug caused by sloppy
>> > code duplication. It will crash without this patch because
>> > fp128 is a valid floating-point type, but we would think
>> > that we had matched a function that used doubles.
>> >
>> > The new helper function can be used to replace similar
>> > checks that are used in several other places in this file.