Fix typo in cmake/modules/CrossCompile.cmake

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 10:29:18 PST 2016


> On Jan 22, 2016, at 9:55 AM, Chris Bieneman <beanz at apple.com> wrote:
> 
> Tom,
> 
> It looks like your patch may be based on out-of-date sources. Did they come from a release branch?

Sorry, this was my bad. I apparently can’t apply patches… The typo is in ToT, and the patch looks good to me. Please commit.

Thanks,
-Chris

> 
> In general this file is sadly in a perpetual state of not getting enough attention. I have grand plans for improving cross-compilation, and it is WAY better than it used to be, but I haven’t really had time to keep pushing ahead on it. There are no current clients of llvm_create_cross_target, but my hope is to combine that with the ExternalProject wrappers I implemented a few months back to have a better way of tracking dependencies between cross and host compilations.
> 
> -Chris
> 
>> On Jan 22, 2016, at 9:25 AM, Vedant Kumar via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> It's strange that the 'toolchain' parameter is ignored. I can't find any users of llvm_create_cross_target. Do you know of any?
>> 
>> vedant
>> 
>>> On Jan 21, 2016, at 7:23 PM, Tom Birch via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>> 
>>> <cross.diff>_______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 



More information about the llvm-commits mailing list